Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Updates following is_recursive flag removal #4199

Merged
merged 6 commits into from
Feb 1, 2024
Merged

chore(docs): Updates following is_recursive flag removal #4199

merged 6 commits into from
Feb 1, 2024

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Jan 29, 2024 •
edited
Loading

Description

Problem*

Followup to #4187 for resolving #4139

Summary*

We no longer need to distinguish between generateIntermediateProof and generateFinalProof. This will go into effect once AztecProtocol/aztec-packages#4221 is merged and released.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested a review from signorecello January 29, 2024 17:56
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 29, 2024
@vezenovm vezenovm mentioned this pull request Jan 29, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

🚀 Deployed on https://65bbc30a6a99dc27d89e03bd--noir-docs.netlify.app

signorecello
signorecello approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@signorecello signorecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @vezenovm, I'll watch the other PR but I'm afraid of completely forgetting why I was watching it and forget to merge this one. Can you help me babysit them please?

@signorecello
Copy link
Contributor

signorecello commented Jan 30, 2024 •
edited
Loading

Maybe this one should be a draft to avoid accidental merging?

@vezenovm vezenovm marked this pull request as draft January 30, 2024 14:29
@vezenovm
Copy link
Contributor Author

I'll watch the other PR but I'm afraid of completely forgetting why I was watching it and forget to merge this one. Can you help me babysit them please?

Yes I will watch as well. These docs changes are due to AztecProtocol/aztec-packages#4221 removing generateIntermediateProof and generateFinalProof just for generateProof.

Base automatically changed from zpedro/recursion_interface to master January 30, 2024 15:28
@vezenovm
Copy link
Contributor Author

vezenovm commented Feb 1, 2024 •
edited
Loading

@signorecello AztecProtocol/aztec-packages#4221 has gone into master so I am marking this ready for review again.

EDIT: I forgot you have already approved, so enabling auto-merge

@vezenovm vezenovm marked this pull request as ready for review February 1, 2024 16:10
@vezenovm vezenovm requested a review from signorecello February 1, 2024 16:10
@vezenovm vezenovm enabled auto-merge February 1, 2024 16:10
@vezenovm vezenovm added this pull request to the merge queue Feb 1, 2024
Merged via the queue into master with commit 96a74bb Feb 1, 2024
33 checks passed
@vezenovm vezenovm deleted the mv/update-how-to-recursion-docs branch February 1, 2024 16:41
TomAFrench added a commit that referenced this pull request Feb 2, 2024
@TomAFrench
Merge branch 'master' into tf/codegen-nargo-reference-docs
d40c81b 
* master: (22 commits)
  feat: remove predicate from `sort` intrinsic function (#4228)
  chore: add test for missing lambda closure environment (#2120) (#4212)
  chore(docs): Updates following `is_recursive` flag removal (#4199)
  fix: from field with constant values (#4226)
  feat: Option expect method (#4219)
  feat: Evaluation of dynamic assert messages (#4101)
  chore(docs): XOR typo in docs (#4223)
  fix: apply range constraints to return values from unconstrained functions (#4217)
  fix(lsp): replace panics with errors (#4209)
  feat: Improve Error Handling for Cargo in Bootstrap Script (#4211)
  fix: prevent declarations of blackbox functions outside of the stdlib (#4177)
  feat: disable unused variable checks on low-level and oracle functions (#4179)
  chore: Rename acir_docs.md to README.md (#4208)
  feat: remove replacement of boolean range opcodes with `AssertZero` opcodes (#4107)
  chore(docs): updating docs to match new recursion interfacee (#4187)
  feat!: Sync commits from `aztec-packages` (#4144)
  feat: multiply first to allow more ACIR gen optimizations (#4201)
  feat: Move bounded_vec into the noir stdlib (#4197)
  chore: simplify marking black box function outputs as solvable (#4194)
  chore(doc): Add docs for `assert_max_bit_size` (#4196)
  ...
@signorecello
Copy link
Contributor

@vezenovm I don't see in which release will this go? Mostly so I can update noir-examples

@vezenovm
Copy link
Contributor Author

vezenovm commented Feb 8, 2024 •
edited
Loading

@signorecello It looks like the PR that includes the sync is still open #4216. PR these docs reflect AztecProtocol/aztec-packages#4221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@signorecello signorecello Awaiting requested review from signorecello

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vezenovm @signorecello @catmcgee